Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Use IP4 localhost form for zmq bind #7163

Merged
merged 1 commit into from
Aug 5, 2024
Merged

[BugFix] Use IP4 localhost form for zmq bind #7163

merged 1 commit into from
Aug 5, 2024

Conversation

njhill
Copy link
Member

@njhill njhill commented Aug 5, 2024

See https://stackoverflow.com/a/8958414

Should address issues #7138, #7118.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

mgoin
mgoin approved these changes Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job finding the reference for this, makes sense!

youkaichao
youkaichao approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the stackoverflow reference is great!

@youkaichao
Copy link
Member

It looks strange to me, why @robertgshaw2-neuralmagic does not met this when he test the functionality. Is it ZMQ version specific?

@youkaichao youkaichao merged commit 003f8ee into vllm-project:main Aug 5, 2024
29 of 32 checks passed
@youkaichao youkaichao mentioned this pull request Aug 5, 2024
Closed
@njhill njhill deleted the zmq-bind-localhost branch August 5, 2024 15:42
@njhill
Copy link
Member Author

njhill commented Aug 5, 2024

It looks strange to me, why @robertgshaw2-neuralmagic does not met this when he test the functionality. Is it ZMQ version specific?

I had the same thought

@robertgshaw2-neuralmagic
Copy link
Collaborator

I am also confused why this issue does not arise in automation or locally

@dtrifiro dtrifiro mentioned this pull request Aug 5, 2024
Closed
sfc-gh-mkeralapura pushed a commit to sfc-gh-mkeralapura/vllm that referenced this pull request Aug 12, 2024
@njhill @sfc-gh-mkeralapura
[BugFix] Use IP4 localhost form for zmq bind (vllm-project#7163)
853d4b0
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Aug 17, 2024
@njhill @kylesayrs
[BugFix] Use IP4 localhost form for zmq bind (vllm-project#7163)
b92d5a7
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
@njhill @Alvant
[BugFix] Use IP4 localhost form for zmq bind (vllm-project#7163)
a1ad201 
Signed-off-by: Alvant <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youkaichao youkaichao youkaichao approved these changes

@mgoin mgoin mgoin approved these changes

@robertgshaw2-neuralmagic robertgshaw2-neuralmagic Awaiting requested review from robertgshaw2-neuralmagic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@njhill @youkaichao @robertgshaw2-neuralmagic @mgoin